Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 3 #707

Merged
merged 5 commits into from
Jun 24, 2017
Merged

Update to webpack 3 #707

merged 5 commits into from
Jun 24, 2017

Conversation

HairyRabbit
Copy link
Contributor

@HairyRabbit HairyRabbit commented Jun 20, 2017

closes #699
closes #705

@vramana vramana mentioned this pull request Jun 20, 2017
@mastilver
Copy link
Collaborator

Thank you for that PR :)

Good call on EXTRACT_PLUGIN_VERSION 👍

Now we just have to wait for: webpack-contrib/extract-text-webpack-plugin#540 and we will be good to go!

@joshwiens
Copy link

joshwiens commented Jun 24, 2017

@mastilver - 3.0.0-beta.3 is out on npm. Any issues, ping me in Slack or on Twitter. Either will make it to my cell phone.

@filipesilva
Copy link

@d3viant0ne I can't seem to find html-webpack-plugin@3.0.0-beta.0 on npm, was it published?

@mastilver
Copy link
Collaborator

mastilver commented Jun 24, 2017

@filipesilva it's extract-text-webpack-plugin@3.0.0-beta.0

@filipesilva
Copy link

Ah, apologies, I misunderstoord 👍

@mastilver
Copy link
Collaborator

@yuffiy Do you mind updating your PR to get the latest extract-text-webpack-plugin?

I'm unable to do it atm

@mastilver
Copy link
Collaborator

@yuffiy @d3viant0ne Thank you for your work! 👍

@jantimon I let you squash, merge and release that :)

@jantimon jantimon merged commit 9665c63 into jantimon:master Jun 24, 2017
@jantimon
Copy link
Owner

It's full backwards compatible so we can just release it as 2.29 right?

@mastilver
Copy link
Collaborator

mastilver commented Jun 24, 2017

@jantimon Yep, no tests for webpack@1/2 have been changed, so I would think there is not breaking changes

@jantimon
Copy link
Owner

Why did you remove the following files?
node_modules/html-webpack-plugin/index.js
node_modules/html-webpack-plugin/lib/loader.js

@jantimon
Copy link
Owner

Thank you so much @d3viant0ne @yuffiy @mastilver for your work :) released as 2.29

@damianobarbati
Copy link

Should this fix the ERROR in TypeError: Cannot read property 'request' of undefined error we currently have with webpack 3?

@damianobarbati
Copy link

Working combo for me:

        "extract-text-webpack-plugin": "3.0.0-beta.3",
        "html-webpack-plugin": "^2.29.0",
        "webpack": "^3.0.0",

@Kingwl
Copy link

Kingwl commented Jun 26, 2017

it's very helpful to me!

@HairyRabbit
Copy link
Contributor Author

Thanks all

@chrisui
Copy link

chrisui commented Jul 26, 2017

Just a heads up it'd be good to add a git release tag so it shows up in the github releases page. Took me a while to realise 2.28.0 isn't the latest and was confused for a while! :)

Thanks for the work on this great plugin!

@zowers
Copy link

zowers commented Jul 26, 2017

@chrisui for some reason commit 2cc10df is not tagged

@mastilver
Copy link
Collaborator

@chrisui done

@chrisui
Copy link

chrisui commented Jul 26, 2017

@mastilver ⭐️

@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 3 issue - ExternalModuleFactoryPlugin - 'request' of undefined Add support for Webpack 3
9 participants